…ertions

Replaces mock expectations with ActionMailer::Base.deliveries count
assertions for #send_waiting_list_emails tests.

Changes:
- 'emails coaches when there are free coach spots' - verifies email delivery
- 'does not email coaches when no coach spots' - verifies no emails sent
- 'emails students when there are free student spots' - verifies email delivery
- 'does not email students when no student spots' - verifies no emails sent

Removes expect(WorkshopInvitationMailer).to receive(:notify_waiting_list) mocks

Replaces mock expectations with ActionMailer::Base.deliveries count
assertions for reminder email tests.

Changes:
- 'emails all attending members' (monthly) - uses _without_delay method
- 'emails all attending members' (workshop) - verifies email delivery count
- 'emails waiting list' - uses _without_delay method

Notes:
- Monthly and waiting list tests remain marked :wip as they were before
- These methods are async and require _without_delay for sync testing

Removes expect(Mailer).to receive(:attendance_reminder) mocks

Replaces mock expectations with ActionMailer::Base.deliveries count
assertions for #send_meeting_emails tests.

Changes:
- 'emails all invitees that are not banned' - verifies email count excludes banned
- 'emails valid invitees only once' - verifies email count excludes already invited

Uses _without_delay method for synchronous testing.

Removes expect(MeetingInvitationMailer).to receive(:invite) mocks

Replaces mock expectations with ActionMailer::Base.deliveries count
assertions for async behavior tests.

Changes:
- 'sends invitation emails' (async context) - verifies email delivery
- 'sends attendance reminder emails' (async context) - verifies email delivery

Uses _without_delay methods for synchronous testing.

Removes remaining expect(WorkshopInvitationMailer).to receive mocks

…ertions

Simplifies after create hook tests by removing mock-based tests
and replacing with direct email delivery verification.

Changes:
- Consolidates two mock-based tests into one email delivery test
- Verifies email is sent and has expected subject

Removes allow().to receive() and have_received() mocks

…ssertions

Replaces spy-based mock test with email delivery verification.

Changes:
- 'sends an eligibility check email' - verifies email delivery count and recipient

Removes allow().to receive() and have_received() mocks

…sertions

Replaces spy-based mock test with email delivery verification.

Changes:
- 'sends an attendance warning email' - finds email by recipient and subject
- Uses flexible matching to account for other emails in deliveries

Removes allow().to receive() and have_received() mocks

… assertions

Replaces expect_any_instance_of mocks with ActionMailer::Base.deliveries
verification for all welcome email scenarios.

Changes:
- First-time coach subscription - verifies email sent and contains 'coach'
- First-time student subscription - verifies email sent and contains 'student'
- Second subscription tests - clears deliveries and verifies no new emails
- Unsubscribe/resubscribe tests - verifies no duplicate emails sent

Adds before hook to clear deliveries for consistent test isolation.

Removes all expect_any_instance_of(MemberMailer) mocks which were
problematic for parallel test execution.

…rtions

Replaces expect_any_instance_of mocks with direct mail content
verification for welcome email tests.

Changes:
- 'sends the coach welcome email to coaches' - verifies email body contains coach text
- 'sends the student welcome email to students' - verifies email body contains student text
- 'sends a ban email to a member' - verifies recipient and email body

Removes all expect_any_instance_of(MemberMailer) mocks which were
problematic for parallel test execution.

The delivery-assertion refactor incorrectly asserted that already-reminded

invitations should have reminded_at as nil. The fabricator sets

reminded_at to 2.days.ago, so the correct assertion is that it

remains unchanged (still ~2 days ago).